Changeset 165

Timestamp:

Jun 10, 2016, 5:52:27 PM (8 years ago)

Author:

g7moreau

Message:

• Replace foreach by for loop

File:

• trunk/klask (modified) (13 diffs)

trunk/klask

@@ -264 +264 @@
    if ($ret{mac_address} ne 'unknow') {
       my @paquets = ();
-      foreach ( split m/ : /xms, $ret{mac_address} ) {
+      for ( split m/ : /xms, $ret{mac_address} ) {
          my @chars = split m//xms, uc "00$_";
          push @paquets, "$chars[-2]$chars[-1]";
@@ -374 +374 @@
    my @paquets = split m/ : /xms, $mac_address;
    my $return = q{};
-   foreach(@paquets) {
+   for (@paquets) {
       $return .= q{.} . digit_hex_to_dec($_);
       }
@@ -437 +437 @@
       # 21->24 45->48
       SWITCH_PORT_IGNORE:
-      foreach my $p (@{$sw->{portignore}}) {
+      for my $p (@{$sw->{portignore}}) {
          next SWITCH_PORT_IGNORE if $swport ne get_numerical_port($sw->{model},$p);
          next LOOP_ON_SWITCH;
@@ -1189 +1189 @@
 
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (Net::Netmask::sort_by_ip_address(keys %{$computerdb})) {
+   for my $ip (Net::Netmask::sort_by_ip_address(keys %{$computerdb})) {
 
 #      next LOOP_ON_IP_ADDRESS if $computerdb->{$ip}{hostname_fq} eq 'unknow';
@@ -1256 +1256 @@
    my %mac_count = ();
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (keys %{$computerdb}) {
+   for my $ip (keys %{$computerdb}) {
 
       # to be improve in the future
@@ -1267 +1267 @@
 
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (Net::Netmask::sort_by_ip_address(keys %{$computerdb})) {
+   for my $ip (Net::Netmask::sort_by_ip_address(keys %{$computerdb})) {
 
       # to be improve in the future
@@ -1445 +1445 @@
    my %swithportdb = ();
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (keys %{$computerdb}) {
+   for my $ip (keys %{$computerdb}) {
       # to be improve in the future
       next LOOP_ON_IP_ADDRESS if $computerdb->{$ip}{hostname_fq} eq ($computerdb->{$ip}{switch_hostname} || $computerdb->{$ip}{switch_description}); # switch on himself !
@@ -1484 +1484 @@
 
    LOOP_ON_RECENT_COMPUTER:
-   foreach my $swpt (keys %swithportdb) {
+   for my $swpt (keys %swithportdb) {
       next LOOP_ON_RECENT_COMPUTER if $swpt =~ m/^\s*0$/;
       next LOOP_ON_RECENT_COMPUTER if $swithportdb{$swpt}->{hostname_fq} !~ m/$RE_FLOAT_HOSTNAME/;
@@ -1491 +1491 @@
       my $src_timestamp = 0;
       LOOP_ON_IP_ADDRESS:
-      foreach my $ip (keys %{$computerdb}) {
+      for my $ip (keys %{$computerdb}) {
          next LOOP_ON_IP_ADDRESS if $computerdb->{$ip}{mac_address} ne  $swithportdb{$swpt}->{mac_address};
          next LOOP_ON_IP_ADDRESS if $computerdb->{$ip}{hostname_fq} =~ m/$RE_FLOAT_HOSTNAME/;
@@ -1731 +1731 @@
 
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (Net::Netmask::sort_by_ip_address(keys %{$computerdb})) {
+   for my $ip (Net::Netmask::sort_by_ip_address(keys %{$computerdb})) {
 
       next LOOP_ON_IP_ADDRESS if $computerdb->{$ip}{hostname_fq} eq ($computerdb->{$ip}{switch_hostname} || $computerdb->{$ip}{switch_description}); # switch on himself !
@@ -1795 +1795 @@
             my $mac_address = $computerdb->{$ip}{mac_address};
             LOOP_ON_DATABASE:
-            foreach my $ip_db (keys %{$computerdb}) {
+            for my $ip_db (keys %{$computerdb}) {
                next LOOP_ON_DATABASE if $computerdb->{$ip_db}{mac_address} ne $mac_address;
                next LOOP_ON_IP_ADDRESS if $computerdb->{$ip_db}{timestamp} > $timestamp_barrier;
@@ -1833 +1833 @@
    print "-------------------------------------------------------------------------------\n";
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (Net::Netmask::sort_by_ip_address(keys %result_ip)) {
+   for my $ip (Net::Netmask::sort_by_ip_address(keys %result_ip)) {
          printf "%-15s %-40s %-16s %s\n", $ip, $result_ip{$ip}->{hostname_fq}, $result_ip{$ip}->{date_last_detection}, $result_ip{$ip}->{vlan};
       }
@@ -1866 +1866 @@
 
    LOOP_ON_IP_ADDRESS:
-   foreach my $ip (Net::Netmask::sort_by_ip_address(keys %result_ip)) {
+   for my $ip (Net::Netmask::sort_by_ip_address(keys %result_ip)) {
 
       $typerow = $typerow eq 'even' ? 'odd' : 'even';