Changeset 216

Timestamp:

Feb 18, 2017, 2:36:44 PM (8 years ago)

Author:

g7moreau

Message:

• status enable and disable manage human readable port (need more real test)

File:

• trunk/klask (modified) (4 diffs)

trunk/klask

@@ -2061 +2061 @@
       }
 
-   my $search_portstatus = $OID_NUMBER{'portUpDown'} .'.'. $port;
-   print "Info: switch $switch_name port $port SNMP OID $search_portstatus\n" if $verbose;
-
    my $sw = $SWITCH_DB{$switch_name};
    my ($session, $error) = Net::SNMP->session( %{$sw->{snmp_param_session}} );
    print "$error \n" if $error;
 
+   # Retrieve numeric port value
+   my $port_num = snmp_get_switchport_num($session, normalize_port_human_readable($port), $verbose ? 'yes' : '');
+   die "Error : Port $port does not exist on switch $switch_name\n" if not $port_num =~ m/^\d+$/;
+
+   my $search_portstatus = $OID_NUMBER{'portUpDown'} .'.'. $port_num;
+   print "Info: switch $switch_name port $port SNMP OID $search_portstatus\n" if $verbose;
+
    my $result = $session->set_request(
       -varbindlist => [$search_portstatus, INTEGER, 1],
       );
+   print $session->error()."\n" if $session->error_status();
 
    $session->close;
@@ -2100 +2105 @@
       }
 
-   my $search_portstatus = $OID_NUMBER{'portUpDown'} .'.'. $port;
-   print "Info: switch $switch_name port $port SNMP OID $search_portstatus\n" if $verbose;
-
    my $sw = $SWITCH_DB{$switch_name};
    my ($session, $error) = Net::SNMP->session( %{$sw->{snmp_param_session}} );
    print "$error \n" if $error;
+
+   # Retrieve numeric port value
+   my $port_num = snmp_get_switchport_num($session, normalize_port_human_readable($port), $verbose ? 'yes' : '');
+   die "Error : Port $port does not exist on switch $switch_name\n" if not $port_num =~ m/^\d+$/;
+
+   my $search_portstatus = $OID_NUMBER{'portUpDown'} .'.'. $port_num;
+   print "Info: switch $switch_name port $port SNMP OID $search_portstatus\n" if $verbose;
 
    my $result = $session->set_request(
@@ -2144 +2153 @@
    # Retrieve numeric port value
    my $port_num = snmp_get_switchport_num($session, normalize_port_human_readable($port), $verbose ? 'yes' : '');
-   die "Error : Port $port not exist on switch $switch_name\n" if not $port_num =~ m/^\d+$/;
+   die "Error : Port $port does not exist on switch $switch_name\n" if not $port_num =~ m/^\d+$/;
 
    my $search_portstatus = $OID_NUMBER{'portUpDown'} .'.'. $port_num;
@@ -2152 +2161 @@
       -varbindlist => [$search_portstatus]
       );
+   print $session->error()."\n" if $session->error_status();
    if (defined $result) {
       print "$PORT_UPDOWN{$result->{$search_portstatus}}\n";
       }
+
+   $session->close;
 
    #system "snmpget -v 1 -c public $switch_name 1.3.6.1.2.1.2.2.1.7.$port";