Changeset 307

Timestamp:

Jul 18, 2018, 9:13:46 PM (6 years ago)

Author:

g7moreau

Message:

• Update some command

File:

• trunk/ddt/ddt (modified) (7 diffs)

trunk/ddt/ddt

@@ -192 +192 @@
    my @domainsetdb = @{$computer_db->{$domainset}};
 
-   for my $value (@domainsetdb) {
-      for my $id (keys %{$value}) {
-         if ($value->{$id}->{'hostname'} eq $hostname) {
-            #print "Error: Hostname already exist: $hostname\n";
-            return 0;
-            }
-         }
+   for my $computer (@domainsetdb) {
+      my ($mac_address, $attribute) = %{$computer};
+      return 0 if $attribute->{'hostname'} eq $hostname;
       }
    return 1;
@@ -219 +215 @@
 
       my @domainsetdb = @{$computer_db->{$domainset_current}};
-      for my $value (@domainsetdb) {
-         for my $id (keys %{$value}) {
-            if ($id eq $mac) {
-               #print "Error: Physical MAC address already exists: $mac\n";
-               return 0;
-               }
-            }
+
+      LOOP_ON_COMPUTER:
+      for my $computer (@domainsetdb) {
+         my ($mac_address, $attribute) = %{$computer};
+         return 0 if $mac_address eq $mac;
          }
       }
@@ -428 +422 @@
 
    my @domainsetdb = @{$computer_db->{$domainset}};
-   my $cpt=0;
-   for my $value (@domainsetdb) {
-      for my $id (keys %{$value}) {
-
-         if ($value->{$id}->{'hostname'} eq $hostname) {
-            print  $value->{$id}->{'alias'};
-            $alias = $alias . ' ' . $value->{$id}->{'alias'};
-            $computer_db->{$domainset}[$cpt]{$id}{'alias'}        = $alias;
-            $computer_db->{$domainset}[$cpt]{$id}{'modify_time'}  = time;
-            ipamdb_save("$COMPUTER_YAML", $computer_db);
-            print "Update attribute alias [OK]\n";
-            exit;
-            }
-         }
-      $cpt=$cpt+1;
+
+   LOOP_ON_COMPUTER:
+   for my $computer (@domainsetdb) {
+      my ($mac_address, $attribute) = %{$computer};
+
+      next LOOP_ON_COMPUTER if $attribute->{'hostname'} ne $hostname;
+
+      $alias .= ' ' . $attribute->{'alias'};
+      $attribute->{'alias'}       = $alias;
+      $attribute->{'modify_time'} = time;
+      ipamdb_save("$COMPUTER_YAML", $computer_db);
+      print "Info: Update attribute alias to $alias for host $hostname [OK]\n";
+      exit;
       }
    }
@@ -472 +464 @@
       'alias'        =>  '',
       }};
-   print "Add the computer: $hostname, IP: $ip, MAC: $mac, Domain Set: $domainset\n";
+   print "Info: Add the host: $hostname, IP: $ip, MAC: $mac, Domain Set: $domainset [OK]\n";
 
    ipamdb_save("$COMPUTER_YAML", $computer_db);
@@ -535 +527 @@
       'comment'      => $comment,
       }};
-   print "Add the computer in pool MAC: $mac, Domain Set: $domainset, Pool: $pool\n";
+   print "Info: Add the computer in pool MAC: $mac, Domain Set: $domainset, Pool: $pool [OK]\n";
 
    ipamdb_save("$COMPUTER_YAML", $computer_db);
@@ -1316 +1308 @@
    my $computer_db = ipamdb_load($COMPUTER_YAML);
 
-   my $computer_index;
    if ( control_exist_mac($computer_db, $mac) == 1 ) {
-      print "Adresse MAC $mac non trouvée.\n";
-      exit;
+      die "Error: Unkown physical MAC address: $mac [FAILED]\n";
       }
 
@@ -1331 +1321 @@
       my @domainsetdb = @{$computer_db->{$domainset_current}};
 
-      $computer_index=0;
-      for my $value (@domainsetdb) {
-         for my $id (keys %{$value}) {
-            if ($id eq $mac) {
-               if ($value->{$id}->{'ip'} eq $pool) {
-                  my $timestamp = time;
-                  $computer_db->{$domainset_current}[$computer_index]->{$id}->{'modify_time'} = $timestamp;
-                  $computer_db->{$domainset_current}[$computer_index]->{$id}->{'enabled'} = 'yes';
-                  ipamdb_save("$COMPUTER_YAML", $computer_db);
-                  print "Réactivation de la machine $mac du pool $pool [OK]\n";
-                  exit;
-                  }
-               else {
-                  print "Réactivation de la machine $mac [FAILED]\n";
-                  print "La machine $mac n'appartient pas au pool $pool.\n";
-                  exit;
-                  }
-               }
-            $computer_index++;
-            }
+      LOOP_ON_COMPUTER:
+      for my $computer (@domainsetdb) {
+         my ($mac_address, $attribute) = %{$computer};
+         next LOOP_ON_COMPUTER if $mac_address ne $mac;
+
+         if ($attribute->{'ip'} ne $pool) {
+            die "Error: Host enable $mac [FAILED]" .
+               " ... The host $mac does not belong to the $pool pool.\n";
+            }
+
+         if ($attribute->{'enabled'} eq 'yes') {
+            print "Info: Host $mac from pool $pool is already enable [OK]" .
+               " ... Status: $attribute->{'enabled'}\n";
+            exit;
+            }
+
+         my $timestamp = time;
+         $attribute->{'modify_time'} = $timestamp;
+         $attribute->{'enabled'}     = 'yes';
+         ipamdb_save("$COMPUTER_YAML", $computer_db);
+         print "Info: Enabling host $mac from pool $pool [OK]" .
+            " ... Status: $attribute->{'enabled'}\n";
+         exit;
          }
       }